Any chance Connie can help here? --
Itamar Syn-Hershko Freelance Developer & Consultant Elasticsearch Partner Microsoft MVP | Lucene.NET PMC http://code972.com | @synhershko <https://twitter.com/synhershko> http://BigDataBoutique.co.il/ On Tue, May 16, 2017 at 10:05 PM, Shad Storhaug <[email protected]> wrote: > > What is required to get all green on dotnetcore ? > > There is an issue that only has been happening when the ThaiAnalyzer tests > are called. An AccessViolationException is thrown from the icu.net > library, indicating that it is writing to protected memory. Actually, I > discovered when running tests for the last release that it can also cause > the test runner to crash when the Highlighter tests are run. > > I tried recording all of the input to icu.net to a file under a failing > test and replaying it back 1500 times so I could submit something fairly > isolated to icu.net as a bug report, but without the interaction with > Lucene.Net it doesn't fail. The two tests that fail are both random tests > with a huge amount of setup code, so isolating where the exact issue is a > major task. > > That said, I was surprised how big of an impact the bug fixes had on the > tests. They may be able to run now if the line to manually fail is removed. > > Unfortunately, the Lucene.Net.Tests.ICU tests (which include these 2) > don't currently run in Visual Studio, so verification needs to be done on > the command line. I wanted to keep the test files in their original > location so they line up with Lucene better, but some weird issue is > causing the tests not to be discovered from files that are referenced > outside of the current project location when using the project.json format. > I have confirmed that upgrading to the new .csproj format will fix this, > and NUnit has (less than 2 weeks ago) released a new alpha version of NUnit > 3 Test Adapter that works with this new format. There is only one more > hurdle to get over to make the switch - come up with a way to switch > between .NET Framework and .NET Core, because it is not currently supported > in the UI: http://stackoverflow.com/questions/43554028/how-do-you- > run-unit-tests-for-a-specific-target-framework-in-visual-studio-2017. The > only intuitive way I know of to do it without having duplicate `.csproj` > files for every project is to use the solution-level multi targeting to add > separate targets for each framework, but NUnit is very picky about how the > file is setup so I am not sure yet whether that will work. It's going to > take some trial and error. > > > > -----Original Message----- > From: [email protected] [mailto:[email protected]] On > Behalf Of Itamar Syn-Hershko > Sent: Wednesday, May 17, 2017 1:23 AM > To: [email protected] > Subject: Re: [Vote] Apache Lucene.Net 4.8.0-beta00003 > > Yay! +1 > > What is required to get all green on dotnetcore ? > > On May 16, 2017 21:02, "Shad Storhaug" <[email protected]> wrote: > > > Third time's a charm. We've fixed the index corruption issue (that > > turns out *only* happens when using x86 in combination with binary doc > > values) which means indexes written under those conditions with prior > > versions may not be able to be read by this version (breaking change). > > > > There were also a few other bugs fixed and for the first time ever > > there were no test failures on .NET Framework. The only tests that > > failed on .NET Core were 2 that have been manually set to fail (since > > .NET Core cannot catch AccessViolationExceptions). We can't say for > > sure that the flakey tests are all fixed, but this is a good sign. > > > > > > > > The source and binary packages are available for inspection at: > > https://dist.apache.org/repos/dist/dev/lucenenet/. > > > > > > > > There is a MyGet feed that can be accessed at: > > > > > > > > V2: https://www.myget.org/F/lucene-net-nuget/api/v2 (VS2012+) > > > > V3: https://www.myget.org/F/lucene-net-nuget/api/v3/index.json > > (VS2015+) > > > > > > > > The tag is: https://github.com/apache/lucenenet/releases/tag/Lucene. > > Net_4_8_0_beta00003 > > > > > > > > > > > > Please review the beta and vote (build and test instructions now on > > the README). > > > > > > > > This vote will close no sooner than 72 hours from now, i.e. sometime > > after > > 18:00 UTC 20-May 2017 > > > > > > > > > > > > +1 - Yes > > > > 0 - Indifferent > > > > -1 - Not ready, because... > > > > Thanks, > > Shad Storhaug (NightOwl888) > > >
