[
https://issues.apache.org/jira/browse/LUCENENET-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16948845#comment-16948845
]
Shad Storhaug commented on LUCENENET-626:
-----------------------------------------
It is believed that IncrementToken() was being called after Dispose() because
of a bug in the test framework that has been addressed. We need verification
that this issue is no longer happening.
> API: Review to ensure IDisposable is being used correctly and disposable
> pattern implemented correctly
> ------------------------------------------------------------------------------------------------------
>
> Key: LUCENENET-626
> URL: https://issues.apache.org/jira/browse/LUCENENET-626
> Project: Lucene.Net
> Issue Type: Task
> Components: Lucene.Net Core, Lucene.Net Demo,
> Lucene.Net.Analysis.Common, Lucene.Net.Analysis.ICU,
> Lucene.Net.Analysis.Kuromoji, Lucene.Net.Analysis.Morfologik,
> Lucene.Net.Analysis.Phonetic, Lucene.Net.Analysis.SmartCN,
> Lucene.Net.Analysis.Stempel, Lucene.Net.Benchmark, Lucene.Net.Classification,
> Lucene.Net.Codecs, Lucene.Net.Expressions, Lucene.Net.Facet,
> Lucene.Net.Grouping, Lucene.Net.Highlighter, Lucene.Net.ICU, Lucene.Net.Join,
> Lucene.Net.Memory, Lucene.Net.Misc, Lucene.Net.Queries,
> Lucene.Net.QueryParser, Lucene.Net.Replicator, Lucene.Net.Sandbox,
> Lucene.Net.Spatial, Lucene.Net.Suggest, Lucene.Net.TestFramework
> Affects Versions: Lucene.Net 4.8.0
> Reporter: Shad Storhaug
> Priority: Major
> Labels: up-for-grabs
> Original Estimate: 50h
> Remaining Estimate: 50h
>
> There have been several issues found recently with the disposable pattern not
> being implemented correctly. I have also been made aware that there is at
> least one class (Lucene.Net.Store.Lock, if I recall correctly) that is
> designed to be re-opened after it is closed.
> We need a review to ensure all classes that implement disposable are doing it
> correctly and have correctly implemented the dispose pattern both for sealed
> and unsealed types. We also need to have a close look at whether any classes
> should be reverted back to using Close() instead of Dispose() on account that
> the class instance was designed to be used again after the Dispose() call.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
