NightOwl888 commented on code in PR #650:
URL: https://github.com/apache/lucenenet/pull/650#discussion_r995875507
##########
Lucene.Net.sln:
##########
@@ -263,7 +263,7 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") =
"Lucene.Net.Tests.AllProject
EndProject
Project("{E24C65DC-7377-472B-9ABA-BC803B73C61A}") = "websites", "websites\",
"{8988CDA4-8420-4BEE-869A-66825055EED2}"
ProjectSection(WebsiteProperties) = preProject
- TargetFrameworkMoniker = ".NETFramework,Version%3Dv4.0"
+ TargetFrameworkMoniker = ".NETFramework,Version%3Dv4.6.2"
Review Comment:
This issue only affects contributors who open the project in Visual Studio
2022. We should probably just bump this to 4.8, since that framework is more
likely to be installed.
##########
.github/workflows/Generate-TestWorkflows.ps1:
##########
@@ -65,7 +65,7 @@ param(
[string]$RepoRoot = (Split-Path (Split-Path $PSScriptRoot)),
- [string[]]$TestFrameworks = @('net6.0', 'net5.0','net461','net48'), #
targets under test: net6.0, netstandard2.1, netstanard2.0, net45
+ [string[]]$TestFrameworks = @('net6.0', 'net5.0','net461','net48'), #
targets under test: net6.0, netstandard2.1, netstanard2.0, net48
Review Comment:
The framework under test in this case would be net462
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
