NightOwl888 commented on issue #717: URL: https://github.com/apache/lucenenet/issues/717#issuecomment-1290655689
Unless we are going to make the effort to migrate to new APIs, IMO it doesn't make much sense to add a new target. In fact, we are evaluating whether to drop one of the targets (either `net462` or `netstandard2.0`), since these have significant overlap and `netstandard2.1` pretty much covers all other platforms except .NET Framework and .NET 6+. However, adding .NET 7 tests to Azure DevOps is a must. Adding .NET 7 tests to GitHub Actions should only be done if we remove the tests for .NET 6, since we only need one set of tests to validate the `net6.0` target and we want the PR tests to run as fast as possible. Adding a target for `net6.0` made sense because: 1. J2N uses [hardware intrinsics](https://devblogs.microsoft.com/dotnet/hardware-intrinsics-in-net-core/) for some of the low level bit operations and `net6.0` supports both Windows and Linux 2. Normal dictionaries support deleting while iterating forward, so we don't have to use `ConcurrentDictionary<TKey, TValue>` Being that we only have a couple of months left of `netcoreapp3.1` support, we should drop those tests but keep the `net5.0` tests for testing the `netstandard2.1` target. `net5.0` makes more sense to use because it supports detecting fatal crashes, where `netcoreapp3.1` does not. It would be best to first do a PR for dropping `netcoreapp3.1` tests, then a PR for adding the `net7.0` tests. ### Azure DevOps / build.bat x64 + x86 on Windows only - `net7.0` -> tests `net6.0` tfm - `net6.0` -> tests `net6.0` tfm - `net5.0` -> tests `netstandard2.1` tfm - `net48` -> tests `net462` tfm - `net461` -> tests `netstandard2.0` tfm (will probably drop both of these) ### GitHub Actions x64 only on all targets - `net7.0` -> tests `net6.0` tfm - `net5.0` -> tests `netstandard2.1` tfm - `net48` -> tests `net462` tfm - `net461` -> tests `netstandard2.0` tfm (will probably drop both of these) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
