NightOwl888 commented on code in PR #738:
URL: https://github.com/apache/lucenenet/pull/738#discussion_r1012537773
##########
src/Lucene.Net.Spatial/Prefix/Tree/QuadPrefixTree.cs:
##########
@@ -379,7 +442,10 @@ protected internal override SpatialPrefixTree NewSPT()
if (m_ctx is null)
throw new InvalidOperationException($"{nameof(m_ctx)} must be
set prior to calling NewSPT().");
- return new QuadPrefixTree(m_ctx, m_maxLevels ??
QuadPrefixTree.MAX_LEVELS_POSSIBLE);
+ //return new QuadPrefixTree(m_ctx, m_maxLevels ??
QuadPrefixTree.MAX_LEVELS_POSSIBLE);
+ QuadPrefixTree tree = new QuadPrefixTree(m_ctx, m_maxLevels ??
QuadPrefixTree.MAX_LEVELS_POSSIBLE);
+ tree.m_robust = getVersion().OnOrAfter(LuceneVersion.LUCENE_48);
Review Comment:
This breaks behavioral compatibility with LUCENE_48. If the user requests
LUCENE_48 compatibility, why would we return behavior that didn't exist until
LUCENE_8_3_0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
