laimis opened a new pull request, #809: URL: https://github.com/apache/lucenenet/pull/809
Continuation of fixes with virtual calls being made from constructors. The issue originally reported by SonarCloud scans: https://sonarcloud.io/project/issues?resolved=false&rules=csharpsquid%3AS1699&id=apache_lucenenet and referenced in this issue: https://github.com/apache/lucenenet/issues/670 This one focuses on RollingBuffer and its subclasses. Instead of providing a virtual NewInstance to override, we accept a factory method in the constructor and use it whenever new instance is needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
