laimis commented on code in PR #823:
URL: https://github.com/apache/lucenenet/pull/823#discussion_r1164999599
##########
src/Lucene.Net/Util/OpenBitSetDISI.cs:
##########
@@ -31,6 +32,8 @@ public class OpenBitSetDISI : OpenBitSet
/// Also give a maximum size one larger than the largest doc id for
which a
/// bit may ever be set on this <see cref="OpenBitSetDISI"/>.
/// </summary>
+ [SuppressMessage("CodeQuality", "IDE0079:Remove unnecessary
suppression", Justification = "This is a SonarCloud issue")]
+ [SuppressMessage("CodeQuality", "S1699:Constructors should only call
non-overridable methods", Justification = "This class will get removed in later
versions of Lucene, see LUCENE-6010")]
public OpenBitSetDISI(DocIdSetIterator disi, int maxSize)
Review Comment:
InPlaceOr that is called makes a call to another virtual FastSet. I believe
that would be harder to fix unless we made it have it call a private version
too. Seems like not worth the effort?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
