laimis commented on code in PR #835:
URL: https://github.com/apache/lucenenet/pull/835#discussion_r1167026651
##########
src/Lucene.Net.Benchmark/Support/TagSoup/ElementType.cs:
##########
@@ -59,6 +62,26 @@ public ElementType(string name, int model, int memberOf, int
flags, Schema schem
localName = GetLocalName(name);
}
+ /// <summary>
+ /// LUCENENET specific constructor that allows the caller to specify
the namespace and local name
+ /// and is provided to subclasses as an alternative to <see
cref="ElementType(string, int, int, int, Schema)"/>
+ /// in order to avoid virtual method calls.
+ /// </summary>
+ public ElementType(
+ string name, int model, int memberOf, int flags, Schema schema,
+ Func<string, bool, string> namespaceFunc,
Review Comment:
Adjusted the constructor to accept namespace and localName strings vs funcs.
I am hesitant to get into big refactoring and focus on getting the sonar
warnings eliminated first, so I didn't touch the rest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
