NightOwl888 commented on code in PR #847:
URL: https://github.com/apache/lucenenet/pull/847#discussion_r1180966978
##########
src/Lucene.Net.Replicator/IndexAndTaxonomyRevision.cs:
##########
@@ -44,35 +44,28 @@ namespace Lucene.Net.Replicator
public class IndexAndTaxonomyRevision : IRevision
{
/// <summary>
- /// A <see cref="DirectoryTaxonomyWriter"/> which sets the underlying
+ /// A <see cref="DirectoryTaxonomyIndexWriterFactory"/> which sets the
underlying
/// <see cref="Index.IndexWriter"/>'s <see
cref="IndexDeletionPolicy"/> to
/// <see cref="SnapshotDeletionPolicy"/>.
/// </summary>
- public class SnapshotDirectoryTaxonomyWriter : DirectoryTaxonomyWriter
+ public class SnapshotDirectoryTaxonomyIndexWriterFactory :
DirectoryTaxonomyIndexWriterFactory
Review Comment:
Being that we have already broken this API, let's de-nest the class as per
[CA1034](https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1034).
And since we repurposed it, let's move it to the `Support` folder of
`Lucene.Net.Replicator` and mark it `// LUCENENET specific`. But keep it in the
same namespace as it is now.
Also, be sure to drop a comment here:
```c#
// LUCENENET specific - refactored SnapshotDirectoryTaxonomyWriter into
SnapshotDirectoryTaxonomyIndexWriterFactory and de-nested
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
