paulirwin opened a new issue, #931: URL: https://github.com/apache/lucenenet/issues/931
Note that we have added `[MethodImpl(MethodImplOptions.NoInlining)]` more liberally than what was actually required. For example, for this case we have added it to every method named `Flush` in the whole solution. There may be a slight performance improvement if we allowed inlining everywhere except for the specific methods that are actually being scanned for in the stack traces of all tests. This is low priority, but perhaps we should add an issue to remove unnecessary `[MethodImpl(MethodImplOptions.NoInlining)]` attributes. An analysis of which specific methods are being scanned for in the stack trace would be required to work this out, though. Or they could be removed one at a time and rolled back if removing the attribute causes a failure in any one of multiple test runs. _Originally posted by @NightOwl888 in https://github.com/apache/lucenenet/pull/926#discussion_r1520982896_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
