paulirwin commented on issue #933:
URL: https://github.com/apache/lucenenet/issues/933#issuecomment-2018773920

   Looks like we could add back the `Fsync` method as part of this change, if 
we were to do it: 
https://github.com/apache/lucenenet/blob/444e6d09ae2451988ff8fcb1d54a00d6a204fd6a/src/Lucene.Net/Store/FSDirectory.cs#L589-L595
   
   Interestingly, the blame shows the most recent commit of that block to be a 
revert of a revert of a commit 😄 cc @NightOwl888 
   
   Also note this from the Java Lucene 4.8.0 release notes:
   ```
   * LUCENE-5588: Lucene now calls fsync() on the index directory, ensuring
     that all file metadata is persisted on disk in case of power failure.
     This does not work on all file systems and operating systems, but Linux
     and MacOSX are known to work. On Windows, fsyncing a directory is not
     possible with Java APIs.  (Mike McCandless, Uwe Schindler)
   ```
   
   I'm going to reopen this issue until we come up with a solution. My instinct 
is to support `Flush(false)` and add back the `Fsync` method, but I'm not an 
expert in this area and I don't fully understand the revert/revert history here 
yet. I'd like Shad's input for sure.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to