NightOwl888 commented on code in PR #951: URL: https://github.com/apache/lucenenet/pull/951#discussion_r1717121215
########## src/dotnet/Lucene.Net.Tests.CodeAnalysis/Lucene.Net.Tests.CodeAnalysis.csproj: ########## @@ -22,7 +22,7 @@ <Project Sdk="Microsoft.NET.Sdk"> <PropertyGroup> - <TargetFramework>net5.0</TargetFramework> + <TargetFramework>net6.0</TargetFramework> Review Comment: When we publish, we publish all target frameworks at the same time at the solution level. It runs this file for every target framework we specify when running the publish command. That overrides what you have specified in this file. We have to explicitly set all of the other target frameworks to false or it will publish and then attempt to run the tests in CI. Also, publishing the test results is done with templates. So, it needs to be updated to `net8.0` or the test results will be generated, but not uploaded to the control panel. https://github.com/stesee/lucenenet/blob/FinalizerFix/.build/azure-templates/publish-test-results-for-test-projects.yml#L77 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
