paulirwin commented on issue #959: URL: https://github.com/apache/lucenenet/issues/959#issuecomment-2355980945
@VahidN Thanks for the feedback. It looks like even in the latest Java Lucene that method is still package-private (kinda-sorta how Java spells "internal") from its default visibility: https://github.com/apache/lucene/blob/b59a357e58611b86e4cc1643794e05dd17d71b08/lucene/misc/src/java/org/apache/lucene/misc/TermStats.java#L35 However, the `termtext` field is public in the upstream code (including in 4.8.0), so we incorrectly ported that as internal: https://github.com/apache/lucene/blob/b59a357e58611b86e4cc1643794e05dd17d71b08/lucene/misc/src/java/org/apache/lucene/misc/TermStats.java#L23 It seems like the most correct fix here is to make the field public (and possibly make it a property like the ones below it), and leave the visibility of `GetTermText()` as internal, although making it public too does seem like a harmless change that could be Lucene.Net-specific. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
