NightOwl888 commented on code in PR #968:
URL: https://github.com/apache/lucenenet/pull/968#discussion_r1792165690
##########
src/Lucene.Net.Replicator/Http/ReplicationService.cs:
##########
@@ -188,24 +188,14 @@ public virtual void Perform(IReplicationRequest request,
IReplicationResponse re
break;
}
}
- catch (Exception e)
+ catch (Exception)
{
response.StatusCode = (int)HttpStatusCode.InternalServerError;
// propagate the failure
- try
- {
- TextWriter writer = new StreamWriter(response.Body);
- JsonSerializer serializer =
JsonSerializer.Create(JSON_SERIALIZER_SETTINGS);
Review Comment:
Sounds good.
##########
src/Lucene.Net.Replicator/Http/ReplicationService.cs:
##########
@@ -81,15 +81,6 @@ public enum ReplicationAction
/// </summary>
public const string REPLICATE_FILENAME_PARAM = "filename";
- /// <summary>
- /// Json Serializer Settings to use when serializing and deserializing
errors.
- /// </summary>
- // LUCENENET specific
- public static readonly JsonSerializerSettings JSON_SERIALIZER_SETTINGS
= new JsonSerializerSettings()
Review Comment:
I titled this PR `BREAKING:` so we can put this in the release notes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
