NightOwl888 commented on code in PR #795:
URL: https://github.com/apache/lucenenet/pull/795#discussion_r1815391191
##########
websites/site/release-notes/version-4.8.0-beta00017.md:
##########
@@ -0,0 +1,177 @@
+---
Review Comment:
The release notes need to be a separate PR from the website update. Release
notes are added prior to the release vote, and the rest of these updates are
added after a successful vote.
The release notes are only done this way because GitHub requires permissions
to view the release notes and we send the vote out to the dev list, so many
interested parties don't have those permissions. Not to mention, the draft
release notes page changes URL every time it is updated.
I spotted a few other potential issues, but I will do a complete review once
this is moved to a new PR.
##########
websites/apidocs/apiSpec/core/Lucene_Net_Codecs.md:
##########
@@ -193,7 +193,7 @@ Here is an example project file for .NET 5 for testing a
project named `MyCodecs
<PackageReference Include="nunit" Version="3.13.2" />
<PackageReference Include="NUnit3TestAdapter" Version="3.17.0" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.11.0" />
- <PackageReference Include="Lucene.Net.TestFramework"
Version="4.8.0-beta00016" />
+ <PackageReference Include="Lucene.Net.TestFramework"
Version="4.8.0-beta00017" />
Review Comment:
Let's bump the above to `.NET 8` on line 183 and
`<TargetFramework>net0.0</TargetFramework>` on line 189.
##########
websites/site/download/version-4.8.0-beta00017.md:
##########
@@ -0,0 +1,69 @@
+---
+uid: download/4.8.0-beta00017
+version: 4.8.0-beta00017
+---
+
+# Download Lucene.Net 4.8.0-beta00017
+
+---
+
+## Lucene 4.8.0-beta00017
+
+_Status:_ **`Beta`**
+
+_Released:_ `2024-10-23`
+
+- Binary release:
**[Lucene.Net-4.8.0-beta00017.bin.zip](https://www.apache.org/dyn/closer.lua/lucenenet/4.8.0-beta00017/Apache-Lucene.Net-4.8.0-beta00017.bin.zip)**
[[PGP](https://downloads.apache.org/lucenenet/4.8.0-beta00017/Apache-Lucene.Net-4.8.0-beta00017.bin.zip.asc)]
[[SHA512](https://downloads.apache.org/lucenenet/4.8.0-beta00017/Apache-Lucene.Net-4.8.0-beta00017.bin.zip.sha512)]
+- Source release:
**[Lucene.Net-4.8.0-beta00017.src.zip](https://www.apache.org/dyn/closer.lua/lucenenet/4.8.0-beta00017/Apache-Lucene.Net-4.8.0-beta00017.src.zip)**
[[PGP](https://downloads.apache.org/lucenenet/4.8.0-beta00017/Apache-Lucene.Net-4.8.0-beta00017.src.zip.asc)]
[[SHA512](https://downloads.apache.org/lucenenet/4.8.0-beta00017/Apache-Lucene.Net-4.8.0-beta00017.src.zip.sha512)]
+- [Change
log](https://github.com/apache/lucenenet/releases/tag/Lucene.Net_4_8_0_beta00017)
+
+<div class="nuget-well" style="text-align:left;">
+ PM> Install-Package Lucene.Net -Version 4.8.0-beta00017
+</div>
+
+### Source code
+
+- [Git Repository](https://github.com/apache/lucenenet)
+
+### Supported Frameworks
+
+- .NET 8.0
+- .NET 6.0
+- [.NET Standard
2.1](https://docs.microsoft.com/en-us/dotnet/standard/net-standard)
+- [.NET Standard
2.0](https://docs.microsoft.com/en-us/dotnet/standard/net-standard)
+- .NET Framework 4.6.2
+
+### Remaining work
+
+See **[Current Status](xref:contributing/current-status)** for more details on
the remaining work
Review Comment:
Yikes, we still link here? That current status page hasn't been updated in
ages. But, maybe we should keep this link and address the link to the WIKI
afterward.
People keep demanding current status, but don't seem to appreciate how much
effort it takes to maintain something like that. It would be nice if we had
some sort of high level view somewhere that is based off of open issues and
milestones, tags, etc. It might be worth investigating the GitHub features
Apache supports with `asf.yaml` to determine whether there is anything like
that where we can provide visibility without too much extra effort.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
