paulirwin commented on code in PR #1014:
URL: https://github.com/apache/lucenenet/pull/1014#discussion_r1836891230
##########
src/Lucene.Net.Tests/Index/TestBinaryDocValuesUpdates.cs:
##########
@@ -1142,46 +1137,17 @@ public virtual void TestUpdateOldSegments()
doc.Add(new BinaryDocValuesField("f", ToBytes(5L)));
writer.AddDocument(doc);
writer.Dispose();
- dir.Dispose();
- }
- [Test, LuceneNetSpecific]
- public virtual void TestUpdateOldSegments_OldFormatNotActive()
- {
- bool oldValue = OldFormatImpersonationIsActive;
-
- OldFormatImpersonationIsActive = false;
-
- Codec[] oldCodecs = new Codec[] {
- new Lucene40RWCodec(),
- new Lucene41RWCodec(),
- new Lucene42RWCodec(),
- new Lucene45RWCodec()
- };
-
- Directory dir = NewDirectory();
- Document doc = new Document();
- doc.Add(new StringField("id", "doc", Store.NO));
- doc.Add(new BinaryDocValuesField("f", ToBytes(5L)));
-
- var conf = NewIndexWriterConfig(TEST_VERSION_CURRENT, new
MockAnalyzer(Random));
- conf.SetCodec(oldCodecs[Random.Next(oldCodecs.Length)]);
-
- var writer = new IndexWriter(dir, conf);
- writer.AddDocument(doc);
+ conf = NewIndexWriterConfig(TEST_VERSION_CURRENT, new
MockAnalyzer(Random));
+ writer = new IndexWriter(dir, conf);
writer.UpdateBinaryDocValue(new Term("id", "doc"), "f",
ToBytes(4L));
-
- try
- {
+ OldFormatImpersonationIsActive = false;
+ try {
Review Comment:
That was unintentional, will fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
