NightOwl888 commented on code in PR #1039:
URL: https://github.com/apache/lucenenet/pull/1039#discussion_r1851520421
##########
.github/workflows/Generate-TestWorkflows.ps1:
##########
@@ -157,12 +151,11 @@ function Write-TestWorkflow(
[string]$RelativeRoot,
[string]$ProjectPath,
[string[]]$Configurations = @('Release'),
- [string[]]$TestFrameworks = @('net5.0', 'net48'),
+ [string[]]$TestFrameworks = @('net6.0', 'net48'),
[string[]]$TestPlatforms = @('x64'),
[string[]]$OperatingSystems = @('windows-latest', 'ubuntu-22.04',
'macos-latest'),
Review Comment:
Can't we now use ubuntu-latest? The message indicates it only breaks the
net5.0 build.
##########
.github/workflows/Generate-TestWorkflows.ps1:
##########
@@ -58,29 +58,23 @@
.PARAMETER DotNet6SDKVersion
The SDK version of .NET 6.x to install on the build agent to be used for
building and
testing. This SDK is always installed on the build agent. The default is
6.0.x.
-
- .PARAMETER DotNet5SDKVersion
- The SDK version of .NET 5.x to install on the build agent to be used for
building and
- testing. This SDK is always installed on the build agent. The default is
5.0.x.
#>
param(
[string]$OutputDirectory = $PSScriptRoot,
[string]$RepoRoot = (Split-Path (Split-Path $PSScriptRoot)),
- [string[]]$TestFrameworks = @('net8.0', 'net5.0','net472','net48'), #
targets under test: net6.0, netstandard2.1, netstanard2.0, net462
+ [string[]]$TestFrameworks = @('net8.0','net6.0','net472','net48'), #
targets under test: net8.0, netstandard2.1, netstandard2.0, net462
- [string[]]$OperatingSystems = @('windows-latest', 'ubuntu-22.04'), # NOTE:
ubuntu-24.04 breaks the .NET 5 build currently
+ [string[]]$OperatingSystems = @('windows-latest', 'ubuntu-22.04'),
Review Comment:
Can't we now use `ubuntu-latest`? The message indicates it only breaks the
`net5.0` build. If so, be sure to also change the filter for .NET Framework
below.
##########
TestTargetFramework.props:
##########
@@ -39,13 +39,12 @@
<!-- Test Client to DLL target works as follows:
Test Client | Target Under Test
net8.0 | net8.0
- net6.0 | net6.0
- net5.0 | netstandard2.1
+ net6.0 | netstandard2.1
net48 | net462
net472 | netstandard2.0
-->
- <TargetFrameworks Condition=" '$(TestFrameworks)' == 'true'
">net8.0;net6.0;net5.0</TargetFrameworks>
Review Comment:
We can delete line 31, also. Those lines are just there to uncomment for
debugging purposes (or rather, to move the comments to the current uncommented
TFM).
##########
README.md:
##########
@@ -25,7 +25,6 @@ The Apache Lucene.NET website is at:
### Lucene.NET 4.8.0
- [.NET 8.0](https://dotnet.microsoft.com/download/dotnet/8.0)
-- [.NET 6.0](https://dotnet.microsoft.com/download/dotnet/6.0)
Review Comment:
This will have to be delayed because the master README file is current with
4.8.0-beta00017 and it will be confusing to users if we change this prior to
the next release. So, we should move this change to a separate PR.
##########
README.md:
##########
@@ -38,8 +37,8 @@ Working toward Lucene.NET 4.8.0 (currently in BETA)
* The beta version is extremely stable
* Has more than 7800+ passing unit tests
-* Integrates well with .NET 8.0 and .NET 6.0 (as well as other unsupported
versions)
Review Comment:
See the note above about delaying this change until the next release.
##########
Directory.Build.targets:
##########
@@ -130,9 +130,9 @@
<DebugType>full</DebugType>
</PropertyGroup>
- <!-- Features in .NET Framework 4.5+ and .NET 6.0+ but not in .NET Standard
2.0 or .NET Standard 2.1 -->
+ <!-- Features in .NET Framework 4.5+ and .NET 8.0+ but not in .NET Standard
2.0 or .NET Standard 2.1 -->
<!-- net472 is used to test .NET Standard 2.0, so we treat it like it is not
part of this group -->
- <PropertyGroup Condition=" ($(TargetFramework.StartsWith('net4')) And
'$(TargetFramework)' != 'net472') Or $(TargetFramework.StartsWith('net6.')) Or
$(TargetFramework.StartsWith('net7.')) Or
$(TargetFramework.StartsWith('net8.')) ">
+ <PropertyGroup Condition=" ($(TargetFramework.StartsWith('net4')) And
'$(TargetFramework)' != 'net472') Or $(TargetFramework.StartsWith('net8.')) Or
$(TargetFramework.StartsWith('net9.')) ">
Review Comment:
The convention in this file is to support all legacy frameworks (except .NET
Core 1.x/.NET Standard 1.x) so we could go back at any time. This serves as
documentation so we can see which historical targets a feature supports. So, we
should add `net9.` without removing `net6.` and `net7.` here and without
changing the description of this group.
##########
src/dotnet/tools/lucene-cli/docs/index.md:
##########
@@ -4,7 +4,7 @@ The Lucene.NET command line interface (CLI) is a new
cross-platform toolchain wi
## Prerequisites
-- [.NET 6.0 Runtime or
Higher](https://dotnet.microsoft.com/en-us/download/dotnet) (.NET 8.0
recommended)
+- [.NET 8.0 Runtime or
Higher](https://dotnet.microsoft.com/en-us/download/dotnet)
Review Comment:
Docs changes that apply to the current release should either be done
directly on the `docs/4.8.0-beta00017` branch and then merged to `master` or be
broken into a separate commit that can be cherry-picked from `master` to
`docs/4.8.0-beta00017`. We can then release a new version of the docs from the
`docs/4.8.0-beta00017` branch which tracks the API of the last release.
##########
websites/site/quick-start/tutorial.md:
##########
@@ -20,10 +20,10 @@ In these examples we will use the .NET CLI (Command Line
Interface) because it's
However you are totally free to use [Visual
Studio](https://visualstudio.microsoft.com/) (Windows/Mac) or [Visual Studio
Code](https://code.visualstudio.com/) (Windows/Unix/Max) to create the console
application project and to add references to the Nuget packages. Whichever tool
you use, you should end up with the same files and you can compare their
contents to the contents that we show in the examples.
## Download and Install the .NET SDK
-First you must install the .NET Core SDK, if it's not already installed on
your machine. The .NET Core SDK contains the .NET runtime, .NET Libraries and
the .NET CLI. If you haven't installed it yet, download it from
https://dotnet.microsoft.com/en-us/download and run the installer. It's a
pretty straightforward process. I'll be using the **.NET 6.0 SDK** in this
tutorial.
+First you must install the .NET Core SDK, if it's not already installed on
your machine. The .NET Core SDK contains the .NET runtime, .NET Libraries and
the .NET CLI. If you haven't installed it yet, download it from
https://dotnet.microsoft.com/en-us/download and run the installer. It's a
pretty straightforward process. I'll be using the **.NET 8.0 SDK** in this
tutorial.
Review Comment:
Docs changes that apply to the current release should either be done
directly on the `docs/4.8.0-beta00017` branch and then merged to `master` or be
broken into a separate commit that can be cherry-picked from `master` to
`docs/4.8.0-beta00017`. We can then release a new version of the docs from the
`docs/4.8.0-beta00017` branch which tracks the API of the last release.
##########
websites/apidocs/apiSpec/core/Lucene_Net_Codecs.md:
##########
@@ -178,7 +178,7 @@ The <xref:Lucene.Net.TestFramework> library contains
specialized classes to mini
> See [Unit testing C# with NUnit and .NET
> Core](https://docs.microsoft.com/en-us/dotnet/core/testing/unit-testing-with-nunit)
> for detailed instructions on how to set up a class library to use with
> NUnit.
> [!NOTE]
-> .NET Standard is not an executable target. Tests will not run unless you
target a framework such as `net6.0` or `net48`.
+> .NET Standard is not an executable target. Tests will not run unless you
target a framework such as `net8.0` or `net48`.
Review Comment:
Docs changes that apply to the current release should either be done
directly on the `docs/4.8.0-beta00017` branch and then merged to `master` or be
broken into a separate commit that can be cherry-picked from `master` to
`docs/4.8.0-beta00017`. We can then release a new version of the docs from the
`docs/4.8.0-beta00017` branch which tracks the API of the last release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
