paulirwin commented on code in PR #1042:
URL: https://github.com/apache/lucenenet/pull/1042#discussion_r1852240284
##########
src/Lucene.Net/Index/SortedSetDocValuesWriter.cs:
##########
@@ -199,26 +201,26 @@ private IEnumerable<BytesRef> GetBytesRefEnumberable(int
valueCount, int[] sorte
}
}
- private IEnumerable<long?> GetOrdsEnumberable(int maxDoc)
+ private IEnumerable<long?> GetOrdCountEnumerable(int maxDoc)
{
- AppendingDeltaPackedInt64Buffer.Iterator iter =
pendingCounts.GetIterator();
+ var iter = pendingCounts.GetIterator();
- if (Debugging.AssertsEnabled) Debugging.Assert(pendingCounts.Count
== maxDoc,"MaxDoc: {0}, pending.Count: {1}", maxDoc, pending.Count);
+ if (Debugging.AssertsEnabled) Debugging.Assert(pendingCounts.Count
== maxDoc, "MaxDoc: {0}, pending.Count: {1}", maxDoc, pending.Count);
- for (int i = 0; i < maxDoc; ++i)
+ for (int docUpto = 0; docUpto < maxDoc; ++docUpto)
{
yield return iter.Next();
}
}
- private IEnumerable<long?> GetOrdCountEnumberable(int maxCountPerDoc,
int[] ordMap)
+ private IEnumerable<long?> GetOrdsEnumerable(int[] ordMap, int
maxCountPerDoc)
{
int currentUpTo = 0, currentLength = 0;
- AppendingPackedInt64Buffer.Iterator iter = pending.GetIterator();
- AppendingDeltaPackedInt64Buffer.Iterator counts =
pendingCounts.GetIterator();
- int[] currentDoc = new int[maxCountPerDoc];
+ var iter = pending.GetIterator();
+ var counts = pendingCounts.GetIterator();
Review Comment:
Alright I'll revert these, I changed this because Rider was throwing this
warning:
https://www.jetbrains.com/help/rider/AccessToStaticMemberViaDerivedType.html
I'll suppress it in code instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
