paulirwin commented on issue #1050:
URL: https://github.com/apache/lucenenet/issues/1050#issuecomment-2513217153
I reviewed the other cases where NoInlining was added so that the stack
trace stays "inspectable," and this case stands out as different. The other
cases are inside test classes that change the behavior at test runtime; in this
case it is only used for an assertion. Based on my rationale above, I've
submitted a PR to comment out this assertion and add a comment explaining why,
rather than disable PGO or force NoInlining. The assertion inside the `try`
block even says what it's testing: `Assert.Fail("Should throw
BooleanQuery.TooManyClauses");` - the important thing here is that the
exception is thrown, not who threw it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
