paulirwin commented on PR #1058: URL: https://github.com/apache/lucenenet/pull/1058#issuecomment-2562026227
I feel confident enough in this now that it is ready for review. This PR achieves the original goals of #271, of not only ensuring that the original issue is fixed, but that we have implemented a design that allows for TokenStreams to be "closed" in a reusable way (via this new `ICloseable` interface to mirror Java) while also still allowing for an extensibility point for them to be "disposed" in a non-reusable way, such as if your TokenStream implementation needs to dispose of native resources or file handles. Additionally, the code in BaseTokenStreamTestCase has been reviewed several times and is now much closer to the original implementation. I've left the try/finally calls, since they probably should have been in the original Java anyways, and it seems to possibly help cascading failures (although I haven't been able to reproduce those, possibly as a result of other previous fixes). With all tests passing reliably, this design change implemented, and all concerns addressed in the original issue, I think it's time to wrap this up and call this 5+ year old issue complete. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
