paulirwin commented on code in PR #1091:
URL: https://github.com/apache/lucenenet/pull/1091#discussion_r1904689317
##########
src/Lucene.Net.Analysis.Common/Analysis/Util/AnalysisSPILoader.cs:
##########
@@ -36,7 +36,7 @@ internal sealed class AnalysisSPILoader<S> where S :
AbstractAnalysisFactory
private readonly string[] suffixes;
public AnalysisSPILoader()
- : this(new string[] { typeof(S).Name })
+ : this(new string[] { nameof(S) })
Review Comment:
Unfortunately we can't use that here, because S is a generic type parameter,
so this will yield `"S"` instead of whatever type is passed into S.
Edit: if it was not apparent from my original comment above, we'll have to
revert this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
