NightOwl888 commented on code in PR #1089:
URL: https://github.com/apache/lucenenet/pull/1089#discussion_r1912352348
##########
src/Lucene.Net/Support/ExceptionHandling/ExceptionExtensions.cs:
##########
@@ -368,9 +372,11 @@ public static bool IsIllegalArgumentException(this
Exception e)
// LUCENENET: In production, there is a chance that we will
upgrade to ArgumentNullExcpetion or ArgumentOutOfRangeException
Review Comment:
Apparently, this comment isn't prominent enough. I missed it on my first
pass, also. There is a copy of this method in the test framework that also
needs to be updated:
https://github.com/apache/lucenenet/blob/Lucene.Net_4_8_0_beta00017/src/Lucene.Net.TestFramework/Support/ExceptionHandling/ExceptionExtensions.cs#L54-L62
I suppose we could cascade the call from `IsIllegalArgumentException()` the
test framework to this one and then exclude `ArgumentNullException` and
`ArgumentOutOfRangeException` from whatever is defined here so these two
methods don't go out of sync.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
