NightOwl888 opened a new issue, #1100:
URL: https://github.com/apache/lucenenet/issues/1100
### Is there an existing issue for this?
- [X] I have searched the existing issues
### Task description
While we probably will have a `Support` folder in the repository for some
time going forward, it is important to enforce the fact that we won't have a
public `Lucene.Net.Support` namespace. This is easier to enforce using a Roslyn
code analyzer than trying to keep track of during reviews because we can easily
miss it.
The developer should get a build failure if they add a public type to the
`Lucene.Net.Support` namespace or any namespace below that namespace. They
should be instructed:
- If the type is not intended for users, make it internal
- If the type is intended for users:
- If it is an adaption of something available in the JDK, consider
submitting it to J2N
- If it is more specialized, move it to an appropriate namespace below
Lucene.Net, such as Lucene.Net.Util
The latter two options can be discussed either on the dev mailing list or on
Slack to help make the right choice.
> Side Note: I noticed that the `Lucene.Net.Support.IO.WindowsFsyncSupport`
type is public and made it into the 4.8.0-beta00017 release. This would make a
good test case for the analyzer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
