paulirwin commented on code in PR #1128:
URL: https://github.com/apache/lucenenet/pull/1128#discussion_r1953268718
##########
src/Lucene.Net/Support/ConcurrentHashSet.cs:
##########
@@ -42,7 +43,8 @@ namespace Lucene.Net.Support
/// concurrently from multiple threads.
/// </remarks>
[DebuggerDisplay("Count = {Count}")]
- internal class ConcurrentHashSet<T> : ISet<T>, IReadOnlyCollection<T>,
ICollection<T>
+ internal class ConcurrentHashSet<T> : ISet<T>, IReadOnlyCollection<T>
+ where T : notnull
Review Comment:
It's more than just avoiding adding tests; the type as-is has nullability
issues if T is allowed to be null. (You can see these if you pull this branch
and remove this constraint.) These would have to be resolved (as well as adding
test coverage for that). I didn't think that was needed in this case, given
that our only usage of the type is where T is not nullable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
