paulirwin commented on code in PR #1134:
URL: https://github.com/apache/lucenenet/pull/1134#discussion_r1986408340
##########
src/Lucene.Net.TestFramework/Codecs/Lucene3x/PreFlexRWTermVectorsFormat.cs:
##########
@@ -54,11 +54,12 @@ protected internal override bool SortTermsByUnicode()
// to each possible target of the StackTraceHelper. If these
change, so must the attribute on the target methods.
if (StackTraceHelper.DoesStackTraceContainMethod("Merge"))
{
- unicodeSortOrder = false;
- if (LuceneTestCase.Verbose)
- {
- Console.WriteLine("NOTE: PreFlexRW codec: forcing
legacy UTF16 vector term sort order");
- }
+ // LUCENENET TODO: This does not seem to be hit, unused?
Review Comment:
I don't currently have an old dev environment set up to be able to run the
Lucene 4.8 Java tests, I can only run the main library code as a Maven
reference. Do you have it set up to run them? If so you could throw an uncaught
exception and see if it fails any tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
