paulirwin commented on code in PR #1138:
URL: https://github.com/apache/lucenenet/pull/1138#discussion_r1988279733
##########
src/Lucene.Net/Store/MMapDirectory.cs:
##########
@@ -314,7 +314,7 @@ internal virtual ByteBuffer[] Map(MMapIndexInput input,
FileStream fc, long offs
input.memoryMappedFile = MemoryMappedFile.CreateFromFile(
fileStream: fc,
mapName: null,
- capacity: length,
+ capacity: fc.Length, // use the full length of the file
Review Comment:
Alright that has been reverted. This means this PR does not attempt to fix
the bug in question, so I've updated the title and description to reflect the
change to the adjust value alone. Given that a race condition is the only way I
can explain the error, and that it has only happened once in tests, I guess we
can just accept this for now. I think we should remove this issue from the
4.8.0 scope as well as a result. If someone runs into this in the wild, they'll
probably find the issue and chime in with better reproduction steps. Or maybe
it was the result of a cosmic ray bit flip and it'll never happen again in the
wild...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
