paulirwin commented on code in PR #1057:
URL: https://github.com/apache/lucenenet/pull/1057#discussion_r2286871151
##########
src/Lucene.Net/Util/UnicodeUtil.cs:
##########
@@ -825,86 +801,41 @@ public static void UTF8toUTF32(BytesRef utf8, Int32sRef
utf32)
/// <summary>
/// Value that all lead surrogate starts with. </summary>
- private const int LEAD_SURROGATE_OFFSET_ = LEAD_SURROGATE_MIN_VALUE -
(SUPPLEMENTARY_MIN_VALUE >> LEAD_SURROGATE_SHIFT_);
+ private const int LEAD_SURROGATE_OFFSET_ =
+ LEAD_SURROGATE_MIN_VALUE - (SUPPLEMENTARY_MIN_VALUE >>
LEAD_SURROGATE_SHIFT_);
/// <summary>
/// Cover JDK 1.5 API. Create a String from an array of <paramref
name="codePoints"/>.
/// </summary>
- /// <param name="codePoints"> The code array. </param>
+ /// <param name="codePoints"> The code point array. </param>
/// <param name="offset"> The start of the text in the code point
array. </param>
/// <param name="count"> The number of code points. </param>
/// <returns> a String representing the code points between offset and
count. </returns>
/// <exception cref="ArgumentException"> If an invalid code point is
encountered. </exception>
- /// <exception cref="ArgumentOutOfRangeException"> If the offset or
count are out of bounds. </exception>
+ /// <exception cref="IndexOutOfRangeException"> If the offset or count
are out of bounds. </exception>
Review Comment:
Good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
