NightOwl888 commented on code in PR #1178: URL: https://github.com/apache/lucenenet/pull/1178#discussion_r2327392729
########## .github/pull_request_template.md: ########## @@ -5,7 +5,7 @@ <!-- If this is your first PR in the Lucene.NET repo, please run through the checklist below to ensure a smooth review and merge process for your PR. --> -- [ ] You've read the [Contributor Guide](https://github.com/apache/lucenenet/blob/main/CONTRIBUTING.md) and [Code of Conduct](https://www.apache.org/foundation/policies/conduct.html). +- [ ] You've read the [Contributor Guide](../CONTRIBUTING.md) and [Code of Conduct](https://www.apache.org/foundation/policies/conduct.html). Review Comment: When submitting a PR, the default view is plain text. So from that perspective, the relative URL cannot be copied and pasted into a browser. `../CONTRIBUTING.md` However, if the user realizes they can click on the Preview tab to get it to resolve to a complete URL, it shouldn't be a problem. Unfortunately, there may be some users who won't come to that realization. The correct absolute URL is: `https://github.com/apache/lucenenet/blob/master/CONTRIBUTING.md` IMO, we should make it absolute unless there is some other trick to make a PR template into a better UX. This template originated from the ASP.NET Core repo and since the cleanup of the URLs were manual, the main > master conversion was overlooked. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
