paulirwin commented on code in PR #1066:
URL: https://github.com/apache/lucenenet/pull/1066#discussion_r2354032440
##########
src/Lucene.Net.Grouping/BlockGroupingCollector.cs:
##########
@@ -342,15 +341,15 @@ public BlockGroupingCollector(Sort groupSort, int
topNGroups, bool needsScores,
/// <param name="fillSortFields">
/// If true then the Comparable values for the sort fields will be set
/// </param>
- public virtual ITopGroups<object> GetTopGroups(Sort withinGroupSort,
int groupOffset, int withinGroupOffset, int maxDocsPerGroup, bool
fillSortFields)
+ public virtual TopGroups<object> GetTopGroups(Sort withinGroupSort,
int groupOffset, int withinGroupOffset, int maxDocsPerGroup, bool
fillSortFields)
Review Comment:
Good catch, this is not needed. And anyone can just manually pass `object`
as the type parameter like we're doing here to the generic version if they
like.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
