Copilot commented on code in PR #1079:
URL: https://github.com/apache/lucenenet/pull/1079#discussion_r2354120883
##########
src/Lucene.Net.Analysis.Common/Analysis/Cjk/CJKBigramFilter.cs:
##########
@@ -251,6 +251,7 @@ public override bool IncrementToken()
}
else
{
+
Review Comment:
Unnecessary blank line added. This appears to be an unintentional whitespace
change that should be removed to maintain clean code formatting.
```suggestion
```
##########
src/Lucene.Net/Store/CompoundFileDirectory.cs:
##########
@@ -131,10 +131,10 @@ public CompoundFileDirectory(Directory directory, string
fileName, IOContext con
}
// LUCENENET NOTE: These MUST be sbyte because they can be negative
- private static readonly sbyte CODEC_MAGIC_BYTE1 =
(sbyte)(CodecUtil.CODEC_MAGIC >>> 24);
- private static readonly sbyte CODEC_MAGIC_BYTE2 =
(sbyte)(CodecUtil.CODEC_MAGIC >>> 16);
- private static readonly sbyte CODEC_MAGIC_BYTE3 =
(sbyte)(CodecUtil.CODEC_MAGIC >>> 8);
- private static readonly sbyte CODEC_MAGIC_BYTE4 =
(sbyte)CodecUtil.CODEC_MAGIC;
+ private const sbyte CODEC_MAGIC_BYTE1 = (sbyte)(CodecUtil.CODEC_MAGIC
>>> 24);
Review Comment:
Inconsistent use of `unchecked` operator. The first line should also use
`unchecked((sbyte)(CodecUtil.CODEC_MAGIC >>> 24))` for consistency, even though
it may not be strictly necessary for that particular cast.
```suggestion
private const sbyte CODEC_MAGIC_BYTE1 =
unchecked((sbyte)(CodecUtil.CODEC_MAGIC >>> 24));
```
##########
src/Lucene.Net.Analysis.Kuromoji/Dict/Dictionary.cs:
##########
@@ -98,9 +98,9 @@ public interface IDictionary
// 'getAdditionalData' if other dictionaries like unidic have
additional data
}
- // LUCENENT TODO: Make this whole thing into an abstact class??
+ // LUCENENET TODO: Make this whole thing into an abstract class??
Review Comment:
Typo in comment: 'abstact' should be 'abstract'.
##########
src/Lucene.Net.Analysis.Kuromoji/Dict/Dictionary.cs:
##########
@@ -98,9 +98,9 @@ public interface IDictionary
// 'getAdditionalData' if other dictionaries like unidic have
additional data
}
- // LUCENENT TODO: Make this whole thing into an abstact class??
+ // LUCENENET TODO: Make this whole thing into an abstract class??
public static class Dictionary // LUCENENET specific: CA1052 Static holder
types should be Static or NotInheritable
{
- public static readonly string INTERNAL_SEPARATOR = "\u0000";
+ public const string INTERNAL_SEPARATOR = "\0";
Review Comment:
Typo in comment: 'abstact' should be 'abstract'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
