paulirwin commented on code in PR #1195:
URL: https://github.com/apache/lucenenet/pull/1195#discussion_r2392805432
##########
src/Lucene.Net.TestFramework/Store/MockIndexOutputWrapper.cs:
##########
@@ -103,6 +104,48 @@ private void CheckDiskFull(byte[] b, int offset, DataInput
@in, long len)
}
}
+ // LUCENENET specific overload
+ private void CheckDiskFull(ReadOnlySpan<byte> source)
Review Comment:
You're right about lambda capture of span, oops. I was indeed using a
parameter in my local csharprepl testing. Even if not refactored into a
callback-style method, maybe the rest of the logic could be refactored out into
separate method calls. Or, just ignore this suggestion and move on, low
priority, no worries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
