NightOwl888 commented on code in PR #14:
URL:
https://github.com/apache/lucenenet-codeanalysis-dev/pull/14#discussion_r2443779706
##########
Directory.Packages.props:
##########
@@ -23,12 +23,11 @@
<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
<CentralPackageTransitivePinningEnabled>true</CentralPackageTransitivePinningEnabled>
</PropertyGroup>
-
<PropertyGroup Label="Shared NuGet Package Reference Versions">
<RoslynAnalyzerPackageVersion>4.14.0</RoslynAnalyzerPackageVersion>
</PropertyGroup>
-
<ItemGroup Label="NuGet Package Reference Versions">
+ <PackageVersion Include="J2N" Version="2.1.0" />
Review Comment:
J2N apparently isn't being used. Please remove it.
##########
src/Lucene.Net.CodeAnalysis.Dev/Utility/Descriptors.LuceneDev6xxx.cs:
##########
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS
+ * OF ANY KIND, either express or implied. See the License for
+ * the specific language governing permissions and limitations
+ * under the License.
+ */
+
+using Microsoft.CodeAnalysis;
+using static Microsoft.CodeAnalysis.DiagnosticSeverity;
+using static Lucene.Net.CodeAnalysis.Dev.Utility.Category;
+
+namespace Lucene.Net.CodeAnalysis.Dev.Utility
+{
+ public static partial class Descriptors
+ {
+ // IMPORTANT: Do not make these into properties!
+ // The AnalyzerReleases release management analyzers do not recognize
them
+ // and will report RS2002 warnings if it cannot read the
DiagnosticDescriptor
+ // instance through a field.
+
+ // 6001: Missing StringComparison argument
+ public static readonly DiagnosticDescriptor
LuceneDev6001_MissingStringComparison =
Review Comment:
Please add a title, description, and message (which can be formatted with
arguments) for each of these diagnostic IDs. This is the information that the
user will see.
https://github.com/NehanPathan/lucenenet-codeanalysis-dev/blob/feature/lucene-dev600x-analyzers/src/Lucene.Net.CodeAnalysis.Dev/Resources.resx#L221
We put them in resource files so we can localize the strings later if we
ever get around to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
