Github user iyerr3 commented on a diff in the pull request:
https://github.com/apache/madlib/pull/197#discussion_r150640177
--- Diff: src/madpack/upgrade_util.py ---
@@ -142,11 +142,11 @@ def _load(self):
"""
# _mad_dbrev = 1.9.1
- if self._mad_dbrev.split('.') < '1.10.0'.split('.'):
+ if map(int,self._mad_dbrev.split('.')) <
map(int,'1.10.0'.split('.')):
--- End diff --
I would recommend using the `_is_rev_gte` and `_get_rev_num` functions as
used in `madpack.py` (eg.
https://github.com/apache/madlib/blob/aed4d9706e59c781f4a83a023358b70b65b84085/src/madpack/madpack.py#L658)
---
