Github user iyerr3 commented on a diff in the pull request:

    https://github.com/apache/madlib/pull/206#discussion_r154242803
  
    --- Diff: src/ports/postgres/modules/stats/correlation.sql_in ---
    @@ -207,8 +203,9 @@ Result:
     </pre>
     
     @par Notes
    -Current implementation ignores a row that contains NULL entirely. This 
means
    -any correlation in such a row (with NULLs) does not contribute to the 
final answer.
    +
    +WARNING: Rows with NULL values will not be ignored. Null values will be
    +replaced by the mean of their respective columns.
    --- End diff --
    
    1. The `@par Notes` adds formatting. Don't need the warning tag. 
    2. I suggest removing the "Rows with NULL values will not be ignored."


---

Reply via email to