Github user kaknikhil commented on a diff in the pull request:

    https://github.com/apache/madlib/pull/243#discussion_r175931022
  
    --- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in ---
    @@ -491,10 +571,28 @@ def _update_temp_model_table(args, iteration, 
temp_output_table, first_try):
             ) rel_state_subq
             {join_clause}
         """.format(insert_or_create_str=insert_or_create_str,
    -               iteration=iteration, join_clause=join_clause, **args)
    +               iteration=iteration, join_clause=join_clause,
    +               internal_result_udf=internal_result_udf, **args)
         plpy.execute(model_table_query)
     
     
    +def _get_loss(schema_madlib, state, is_mini_batch):
    --- End diff --
    
    This function is not used anywhere. 


---

Reply via email to