Github user iyerr3 commented on a diff in the pull request:
https://github.com/apache/madlib/pull/266#discussion_r182921752
--- Diff: src/madpack/upgrade_util.py ---
@@ -82,16 +82,21 @@ def _get_function_info(self, oid):
proname,
textin(regtypeout(prorettype::regtype)) AS rettype,
CASE array_upper(proargtypes,1) WHEN -1 THEN ''
- ELSE
textin(regtypeout(unnest(proargtypes)::regtype))
+ ELSE textin(regtypeout(foo))
END AS argtype,
CASE WHEN proargnames IS NULL THEN ''
- ELSE unnest(proargnames)
+ ELSE bar
END AS argname,
CASE array_upper(proargtypes,1) WHEN -1 THEN 1
- ELSE generate_series(0, array_upper(proargtypes,
1))
+ ELSE zee
END AS i
FROM
- pg_proc AS p
+ (SELECT *, oid,
+ unnest(proargtypes)::regtype AS foo,
--- End diff --
why the non-meaningful names? And while we're here, could we please add
some comments on what's happening in the query?
---
