Github user njayaram2 commented on a diff in the pull request:
https://github.com/apache/madlib/pull/271#discussion_r192174800
--- Diff: src/madpack/upgrade_util.py ---
@@ -1299,18 +1303,19 @@ def _clean_function(self):
pattern = re.compile(r"""CREATE(\s+)FUNCTION""", re.DOTALL |
re.IGNORECASE)
self._sql = re.sub(pattern, 'CREATE OR REPLACE FUNCTION',
self._sql)
- def cleanup(self, sql):
+ def cleanup(self, sql, algoname):
--- End diff --
Good catch, this is dead code.---
