[GitHub] madlib pull request #289: RF: Add impurity variable importance

[jingyimei]

Github user jingyimei commented on a diff in the pull request:

    https://github.com/apache/madlib/pull/289#discussion_r201489373
  
    --- Diff: src/modules/recursive_partitioning/DT_impl.hpp ---
    @@ -1512,6 +1512,9 @@ DecisionTree<Container>::computeVariableImportance(
                         uint64_t maj_count = getMajorityCount(node_index);
                         uint64_t min_count =  node_count - maj_count;
     
    +                    if (min_count == 0) {
    --- End diff --
    
    We can leave some comment here to address it later


---