Github user iyerr3 commented on the issue:
https://github.com/apache/madlib/pull/292
Yeah, the unit tests are unnecessary after this change. I vote to remove
them, with just the function added back to the original PR.
On Thu, Jul 12, 2018 at 5:26 PM Arvind Sridhar <[email protected]>
wrote:
> Sounds good-just verified that plpy converts the SQL bool into a Python
> bool and not a Python string. It should be good to go now. Do we still
want
> to get rid of the unit tests now given that they would be almost trivial
> (basically just checking that True=True)?
>
> â
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/madlib/pull/292#issuecomment-404689919>, or
mute
> the thread
>
<https://github.com/notifications/unsubscribe-auth/ACIkB4YIj74cPd8eTkH4Qxbc5-jifkxGks5uF-lAgaJpZM4VNhMW>
> .
>
---
