Github user ArvindSridhar commented on a diff in the pull request:
https://github.com/apache/madlib/pull/291#discussion_r205953644
--- Diff: src/ports/postgres/modules/utilities/validate_args.py_in ---
@@ -513,11 +513,12 @@ def array_col_has_same_dimension(tbl, col):
# ------------------------------------------------------------------------
-def explicit_bool_to_text(tbl, cols, schema_madlib):
+def explicit_bool_to_text(tbl, cols, schema_madlib, is_forced=False):
--- End diff --
That's a good point-we added this arg to make our dev-check pass, because
our dev check didn't have an explicit ::TEXT cast and yet it was running on
PG10, which supports bool to text casting. Would removing the dev check test
and the is_forced arg be the better way to go?
---
