Github user orhankislal commented on a diff in the pull request:
https://github.com/apache/madlib/pull/311#discussion_r210687181
--- Diff:
src/ports/postgres/modules/utilities/test/unit_tests/test_transform_vec_cols.py_in
---
@@ -125,23 +125,24 @@ class Vec2ColsTestSuite(unittest.TestCase):
def test_get_names_for_split_output_cols_feature_names_none(self):
self.plpy_mock_execute.return_value = [{"n_x": 3}]
- new_cols =
self.subject.get_names_for_split_output_cols(self.default_source_table,
'foobar', None)
+ new_cols =
self.subject.get_names_for_split_output_cols(self.default_source_table,
'foobar')
self.assertEqual(['f1', 'f2', 'f3'], new_cols)
- def test_get_names_for_split_output_cols_feature_names_not_none(self):
- self.plpy_mock_execute.return_value = [{"n_x": 3}]
- new_cols =
self.subject.get_names_for_split_output_cols(self.default_source_table,
'foobar', ['a', 'b', 'c'])
- self.assertEqual(['a', 'b', 'c'], new_cols)
+ # def
test_get_names_for_split_output_cols_feature_names_not_none(self):
--- End diff --
We should remove these commented lines.
---
