Github user kaknikhil commented on a diff in the pull request:
https://github.com/apache/madlib/pull/318#discussion_r216438294
--- Diff: src/madpack/diff_udf.sql ---
@@ -142,9 +142,12 @@ DROP TABLE IF EXISTS functions_madlib_new_version;
SELECT get_functions('madlib_old_vers');
SELECT
+ type,
--'\t-' || name || ':' || '\n\t\t-rettype: ' || retype ||
'\n\t\t-argument: ' || argtypes
- ' - ' || name || ':' || '\n rettype: ' || retype || '\n
argument: ' || argtypes AS "Dropped UDFs"
- , type
+ ' - ' || name || ':' AS "Dropped UDF part1",
--- End diff --
I think it would be helpful to add comments in the commit description
explaining the reasoning behind modifying the `diff_udf.sql` and
`diff_udt.sql`. Just looking at these changes, it's hard to know why for ex
`rettype` was removed and why we need `part1` at the end
---
