Github user iyerr3 commented on a diff in the pull request:

    https://github.com/apache/madlib/pull/320#discussion_r217260823
  
    --- Diff: src/ports/postgres/cmake/PostgreSQLUtils.cmake ---
    @@ -82,8 +82,7 @@ function(determine_target_versions OUT_VERSIONS)
                         set(VERSION "4.3ORCA")
                     endif()
                 elseif(${PORT_UC} STREQUAL "POSTGRESQL" AND
    -                    (${${PORT_UC}_VERSION_MAJOR} EQUAL 10 OR
    -                    ${${PORT_UC}_VERSION_PATCH} GREATER 10))
    --- End diff --
    
    The intention was to check for `...VERSION_MAJOR >= 10`. Hence the two 
checks - there was, however a typo with the second version input as `...PATCH` 
instead of `...MAJOR`. The correction should be to replace the `_PATCH` with 
`_MAJOR`. 


---

Reply via email to