jingyimei commented on a change in pull request #359: DL: Remove eval statement
URL: https://github.com/apache/madlib/pull/359#discussion_r270526208
##########
File path: src/ports/postgres/modules/deep_learning/madlib_keras.py_in
##########
@@ -502,9 +506,13 @@ def evaluate(schema_madlib, model_table, source_table,
id_col,
_, updated_weights = KerasWeightsSerializer.deserialize_weights(
model_data, model_shapes)
model.set_weights(updated_weights)
- compile_params_args = convert_string_of_args_to_dict(compile_params)
+ optimizers = get_optimizers()
+ (opt_name,final_args,compile_dict) = parse_compile_params(compile_params)
with K.tf.device(device_name):
- model.compile(**compile_params_args)
+
+ model.compile(optimizer=optimizers[opt_name](**final_args),
+ loss=compile_dict['loss'],
Review comment:
one space left
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
