kaknikhil commented on a change in pull request #361: Minibatch Preprocessor
DL: Add optional num_classes param.
URL: https://github.com/apache/madlib/pull/361#discussion_r271056887
##########
File path: src/ports/postgres/modules/utilities/minibatch_preprocessing.py_in
##########
@@ -363,21 +365,70 @@ class MiniBatchPreProcessorDL(MiniBatchPreProcessor):
self._validate_args()
self.num_of_buffers = self._get_num_buffers()
- self.to_one_hot_encode = True
Review comment:
Also I think we should document the fact that our implementation of one hot
encoding the dep var is consistent with the output of keras.to_categorical.
IMO, we should document this in our code as well as the docs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
