orhankislal commented on a change in pull request #364: WCC: Performance 
Improvement
URL: https://github.com/apache/madlib/pull/364#discussion_r273659926
 
 

 ##########
 File path: src/madpack/madpack.py
 ##########
 @@ -666,14 +666,16 @@ def _process_py_sql_files_in_modules(modset, args_dict):
             if madpack_cmd == 'install-check':
                 mask = maddir_mod_sql + '/' + module + '/test/*.ic.sql_in'
             else:
-                mask = maddir_mod_sql + '/' + module + '/test/*[!ic].sql_in'
 
 Review comment:
   This masks the `wcc` away because it ends with the character `c`. Any test 
that has `i` or `c` as their last letter would be filtered out.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to