kaknikhil commented on a change in pull request #370: DL: Support response and prob prediction outputs URL: https://github.com/apache/madlib/pull/370#discussion_r276765419
########## File path: src/ports/postgres/modules/deep_learning/madlib_keras_helper.py_in ########## @@ -0,0 +1,96 @@ +# coding=utf-8 Review comment: IMO, we shouldn't name this file `madlib_keras_helper.py_in` because this will just become a catch-all for all things related to deep learning. Naming it helper makes it harder to navigate through code and maintain it in the long term. For ex the function `expand_input_dims` can be in a file called something along the lines`all_things_numpy.py_in` and this file can be called `predict_input_params.py_in`. Having said all this, I will leave the final decision up to you to decide and even if you plan to change this we can do it in a future PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
