kaknikhil commented on a change in pull request #372: DL: Trap unsupported
options for compile and fit params
URL: https://github.com/apache/madlib/pull/372#discussion_r279023055
##########
File path:
src/ports/postgres/modules/deep_learning/test/unit_tests/test_madlib_keras.py_in
##########
@@ -178,11 +178,19 @@ class MadlibKerasFitTestCase(unittest.TestCase):
def test_split_and_strip(self):
self.assertEqual(('a','b'), self.subject.split_and_strip(' a = b '))
- def test_parse_fit_params(self):
+ def test_parse_and_validate_fit_params(self):
Review comment:
We should also add negative test cases for `parse_and_validate_fit_params`
and `parse_compile_params`. Maybe not now but in a future PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
