reductionista commented on a change in pull request #383: Dl/remove hardcode
URL: https://github.com/apache/madlib/pull/383#discussion_r280623162
##########
File path: src/ports/postgres/modules/deep_learning/madlib_keras.sql_in
##########
@@ -158,12 +161,13 @@ CREATE AGGREGATE MADLIB_SCHEMA.fit_step(
/* architecture */ TEXT,
/* compile_params */ TEXT,
/* fit_params */ TEXT,
- /* use_gpu */ BOOLEAN,
+ /* gpus_per_host */ INTEGER,
+ /* segments_per_host */ INTEGER,
/* previous_state */ BYTEA
)(
STYPE=BYTEA,
SFUNC=MADLIB_SCHEMA.fit_transition,
- m4_ifdef(`__POSTGRESQL__', `', `prefunc=MADLIB_SCHEMA.fit_merge,')
Review comment:
I'm not sure if this was here before and I missed it, or if it's new. Looks
like this would break postgres support, but I haven't tested it--was this
change intentional?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
