njayaram2 commented on a change in pull request #385: DL: Make metrics and loss
optional compile parameters
URL: https://github.com/apache/madlib/pull/385#discussion_r281880410
##########
File path: src/ports/postgres/modules/deep_learning/test/madlib_keras.sql_in
##########
@@ -318,7 +318,7 @@ SELECT madlib_keras_fit(
'independent_var',
'model_arch',
1,
- $$ optimizer=Adam(epsilon=None), loss=losses.categorical_crossentropy,
metrics=['accuracy']$$::text,
+ $$ optimizer=Adam(epsilon=None), loss='categorical_crossentropy',
metrics=['accuracy']$$::text,
Review comment:
Quick question, what would happen if `loss=losses.categorical_crossentropy`,
i.e., with the `losses.` prefix?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
